Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSError handling in find_imports_in_file #2331

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Add OSError handling in find_imports_in_file #2331

merged 1 commit into from
Feb 18, 2025

Conversation

kobarity
Copy link

This PR fixes #2330.

staticdev
staticdev approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kobarity and @DanielNoord

@staticdev staticdev added the bug Something isn't working label Feb 18, 2025
@staticdev staticdev merged commit 6f29cb9 into PyCQA:main Feb 18, 2025
1 check passed
@DanielNoord
Copy link
Member

@staticdev You're not going to believe it, but I think this broke the tests main again...

.mksymlinkto is not available on Windows.

@DanielNoord DanielNoord mentioned this pull request Feb 18, 2025
Merged
@kobarity
Copy link
Author

Sorry, I did not test on Windows.
How about #2369?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticdev staticdev staticdev approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isort-identify-imports fails if there are unreadable files in the directory
3 participants
@kobarity @DanielNoord @staticdev