-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README file for the examples directory + years corrections #322
Conversation
Where is the Travis CI check?! |
This looks good to me! But I'm not sure why Travis isn't working. Maybe we can go ahead and merge this one and open a new PR for testing/fixing the Travis build. |
I checked on Travis-CI. We are getting an error saying: "Could not authorize build request for PyAbel/PyAbel", which I think basically means that our "subscription expired". My guess is that, when we moved from travis-ci.org to travis-ci.com, we somehow got switched from an open-source project to a trail commercial subscription and this trial ran out. I emailed them to see if they can fix it. Open source projects are supposed to be free-of-charge. |
Okay, it looks like we weren't signed up for any of their plans. I signed us up for the "free" plan, which gives us 10,000 free minutes of build time. Since we only use a few minutes per month, this should last for many years. If we require more minutes, then we can just ask for some free minutes for our open-source-software project. If you make a new commit to this PR, I think that it should trigger the travis build. |
Thanks, @DanHickstein, for reviewing and solving the unexpected Travis CI problem! |
I've added some technical corrections to the documentation:
P.S. Travis now works again. Thanks, Dan! :–) |
Yes, it looks like travis-ci now supports Windows and macOS testing! So, we can certainly enable Mac testing and maybe also switch to travis for our Windows testing. I have nothing against Appveyor, but I think that we were only using them because Travis didn't support windows testing. One-stop-shopping seems nice. I opened #323 to discuss this.
Huh, that's weird. Links in the docs seem to be working based on a few random clicks.
Yes, seems like the best option.
Great!
Awesome! I realized that the Travis builds actually "cost" at least 10 credits per build minute: https://docs.travis-ci.com/user/billing-overview/ So, I asked for more credits and they gave us 25,000 more for our open source software project. I think that we'll just need to ask for more every few years when they run out. |
I in fact can check the old logs (found the link that you gave me) and don't see such warnings in the previous build. However, it reports Should I then merge this PR now to let you work on #323? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are a perfectionist @MikhailRyazanov. Good work.
@@ -191,12 +191,12 @@ Citation | |||
|
|||
First and foremost, please cite the paper(s) corresponding to the implementation of the Abel transform that you use in your work. The references can be found at the links above. | |||
|
|||
If you find PyAbel useful in you work, it would bring us great joy if you would cite the project. You can find the DOI for the lastest verison `here <https://dx.doi.org/10.5281/zenodo.594858>`_ | |||
If you find PyAbel useful in you work, it would bring us great joy if you would cite the project. You can find the DOI for the lastest verison `here <https://dx.doi.org/10.5281/zenodo.594858>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the article citation should come first, otherwise authors may cite the zenodo instead of the publication?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
Addressing #321: a short README.txt file in the
examples
directory to clarify that the scripts should be run there.And minor corrections to the v0.8.4 release information: