Density Function Re-Work #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Final result:
|
|
Please add a way to extract all the .chunk files in our extractor, i only see one single chunk.json file |
Should be good now |
|
Great work @kralverde (like always 🙃). The new implementation definitely looks cleaner, Hope this also helps with Biomes. Thank you @kralverde ❤️ |
urisinger
pushed a commit
to urisinger/Pumpkin
that referenced
this pull request
Feb 16, 2025
* add density function parser, re-write functionality, and add initial tests * add more tests and fix typo * re-work density interpolator * re-work flat cache * re-work the rest of the chunk specific density functions * re-work fill functions * tweak sample logic and do some refactoring * convert chunk noise to use new density functions * work on porting proto chunk * port proto chunk * add cell cache test * fix wrapper functions * remove test print * update benchmark * rework again * rework again pt 2 * classic off by one * reduce components on the stack by 60x * aquifer tweaks * add multi noise sampler for biome sampling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a density function extractor and reworks density functions as a stack of components to allow for easy mutation of state.
The end goal of this PR is to make the density function code cleaner and more readable, remove unsafe code, and to separate density functions from the chunk noise generator to allow ease of use with other dependencies such as biome generation. (maybe we'll get a performance boost too)
For use with Pumpkin-MC/Extractor#3
Testing
Please follow our Coding Guidelines