Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Splash Potion Implementation #523

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Initial Splash Potion Implementation #523

wants to merge 1 commit into from
+401 −42

Conversation

OfficialKris
Copy link
Contributor

Description

Splash potions!

Implements the structures to allow potions in inventory, use, and broadcast to other players. No effects in this PR.

Testing

  • 2 clients
  • add potion to inventory
  • use potion
  • see correct behavior in both clients

TODO:

  • potion splash and entity color match potion used
  • potion effect and entity land on calculated distance
  • use entity tick system

Snowiiii
Snowiiii reviewed Jan 31, 2025
View reviewed changes
pumpkin/src/server/mod.rs
});
threaded_world
.broadcast_packet_all(&CLevelEvent::new(
2007,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a enum for this afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snowiiii Snowiiii Snowiiii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OfficialKris @Snowiiii