Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pumpkin-config #303

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Commandcracker
Copy link
Contributor

@Commandcracker Commandcracker commented Nov 17, 2024

Description

Most changes are because serde_inline_default is no longer needed, see here

Testing

ran diff on booth configs to see if anything changed.

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings cargo clippy

@Snowiiii
Copy link
Member

The only reason we use serde_inline_default is to have default values for config fields we can't parse. I tested your changes and removed a random config value. It gave me an error Couldn't parse config at "configuration.toml". Reason: missing field hardcore. This is is proberbly caused by an Config update, Just delete the old Config and start Pumpkin again

@Commandcracker Commandcracker marked this pull request as draft November 17, 2024 20:09
@Commandcracker Commandcracker marked this pull request as ready for review November 18, 2024 20:40
@Commandcracker
Copy link
Contributor Author

The only reason we use serde_inline_default is to have default values for config fields we can't parse. I tested your changes and removed a random config value. It gave me an error Couldn't parse config at "configuration.toml". Reason: missing field hardcore. This is is proberbly caused by an Config update, Just delete the old Config and start Pumpkin again

Now it should work

@Snowiiii
Copy link
Member

Just tested again. Works fine now and looks much better.
Thanks @Commandcracker :D

@Snowiiii Snowiiii merged commit 5cd460f into Pumpkin-MC:master Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants