Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx Tests #477

Merged
merged 19 commits into from
Sep 20, 2022
Merged

FIx Tests #477

merged 19 commits into from
Sep 20, 2022

Conversation

adelavega
Copy link
Member

@adelavega adelavega commented Sep 9, 2022

Due to many upgrades (in particular Librosa), many tests are failing due to slightly different values.

I'm relaxing many tests to prevent this from happening so frequently.

NLTK also requires more granular resource management now.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Base: 75.89% // Head: 75.64% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (6e35af0) compared to base (32e41e1).
Patch coverage: 52.94% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   75.89%   75.64%   -0.26%     
==========================================
  Files          65       65              
  Lines        3854     3876      +22     
==========================================
+ Hits         2925     2932       +7     
- Misses        929      944      +15     
Impacted Files Coverage Δ
pliers/extractors/__init__.py 100.00% <ø> (ø)
pliers/extractors/api/__init__.py 100.00% <ø> (ø)
pliers/extractors/api/microsoft.py 33.33% <ø> (-1.12%) ⬇️
pliers/extractors/text.py 96.28% <40.00%> (-0.72%) ⬇️
pliers/stimuli/text.py 86.82% <40.00%> (-1.98%) ⬇️
pliers/filters/text.py 89.21% <52.38%> (-9.61%) ⬇️
pliers/extractors/models.py 93.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adelavega
Copy link
Member Author

Hallelujah!

@adelavega adelavega merged commit 6e5e23b into master Sep 20, 2022
@adelavega adelavega deleted the fix/tests branch September 20, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants