-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Clarifai-GRPC library #474
Conversation
@emdupre Tests are passing with the new library. As far as the user is concerned, there shouldn't be too many differences except that now you need: A When you sign up for Clarifai, you can get your PAT from your profile, and you create an app which will then generate the other two IDs. Tests are probably going to fail in CI but they are passing locally, so give it a shot in this PR if you have time. Otherwise, this is ready to merge. Unless @qmac you want to review real quick. |
Thanks, @adelavega !! I have it annotating some stimuli now, so these changes definitely get things running again ! 🚀 A few small things I was confused by :
|
Great! Thanks for that catch on the environment name. In the docs when I said "(and subclasses) " I meant to include the ImageExtractor. Maybe I could put: "e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM ! Thank you again for working on this 🙏
Awesome thank you! I'll merge as soon as I can get tests passing |
Co-authored-by: Elizabeth DuPre <[email protected]>
…ers into fix/clarifaiapi
Codecov ReportBase: 75.64% // Head: 75.30% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 75.64% 75.30% -0.35%
==========================================
Files 65 65
Lines 3876 3895 +19
==========================================
+ Hits 2932 2933 +1
- Misses 944 962 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes #469
In order to make a call now, you also need to provide a
CLARIFAI_USER_ID
andCLARIFAI_APPLICATION_ID
in addition to yourCLARIFAI_ACCESS_TOKEN
.TODO: