Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add video #454

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Apr 6, 2021

Adds @adelavega's excellent video explaining pliers at the TOP, since people like watching things more than reading, and link corresponding tutorial/course in readme.

@adelavega
Copy link
Member

As flattered as I am James, maybe the link to the tutorial is sufficient? Only because this is domain specific to fmri/neuroimaging and in theory pliers is a domain general tool.

@jdkent
Copy link
Contributor Author

jdkent commented Apr 7, 2021

I think it's still good to have the video directly linked (I think it's a good sign that shows project vitality, investment, and people sometimes prefer to watch something versus read), but I conceded and put the video in Documentation with a disclaimer that pliers is a general-purpose tool.

If the video becomes too out of date we can remove it (or replace it?)

How does that sound?

@codecov-io
Copy link

codecov-io commented Apr 7, 2021

Codecov Report

Merging #454 (42326c1) into master (0ed1f89) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   75.78%   75.46%   -0.32%     
==========================================
  Files          65       65              
  Lines        3820     3779      -41     
==========================================
- Hits         2895     2852      -43     
- Misses        925      927       +2     
Impacted Files Coverage Δ
pliers/converters/api/wit.py 45.65% <0.00%> (-2.27%) ⬇️
pliers/diagnostics/diagnostics.py 88.29% <0.00%> (-2.13%) ⬇️
pliers/support/decorators.py 80.00% <0.00%> (-1.82%) ⬇️
pliers/transformers/api/google.py 40.00% <0.00%> (-1.18%) ⬇️
pliers/transformers/api/microsoft.py 25.00% <0.00%> (-1.16%) ⬇️
pliers/stimuli/api.py 37.73% <0.00%> (-1.16%) ⬇️
pliers/converters/api/revai.py 25.75% <0.00%> (-1.11%) ⬇️
pliers/converters/api/ibm.py 24.71% <0.00%> (-0.84%) ⬇️
pliers/converters/base.py 90.00% <0.00%> (-0.63%) ⬇️
pliers/extractors/api/clarifai.py 22.40% <0.00%> (-0.62%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed1f89...42326c1. Read the comment docs.

@jdkent
Copy link
Contributor Author

jdkent commented Apr 7, 2021

for whatever reason, the doc build now requires pytest, I added pytest to the doc requirements and refactored setup.py so that the requirements in setup.py will be the same as the requirements in the files.

ready for review @adelavega

@jdkent jdkent requested a review from adelavega April 7, 2021 18:32
Copy link
Member

@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelavega adelavega merged commit 9b10b27 into PsychoinformaticsLab:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants