-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add video #454
[DOC] Add video #454
Conversation
As flattered as I am James, maybe the link to the tutorial is sufficient? Only because this is domain specific to fmri/neuroimaging and in theory pliers is a domain general tool. |
I think it's still good to have the video directly linked (I think it's a good sign that shows project vitality, investment, and people sometimes prefer to watch something versus read), but I conceded and put the video in Documentation with a disclaimer that pliers is a general-purpose tool. If the video becomes too out of date we can remove it (or replace it?) How does that sound? |
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 75.78% 75.46% -0.32%
==========================================
Files 65 65
Lines 3820 3779 -41
==========================================
- Hits 2895 2852 -43
- Misses 925 927 +2
Continue to review full report at Codecov.
|
for whatever reason, the doc build now requires pytest, I added pytest to the doc requirements and refactored setup.py so that the requirements in setup.py will be the same as the requirements in the files. ready for review @adelavega |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds @adelavega's excellent video explaining pliers at the TOP, since people like watching things more than reading, and link corresponding tutorial/course in readme.