Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] access string in numpy array #422

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Sep 23, 2020

looks like one of the changes in #418 had a regression with the Google API,

This pull request aims to fix the regression.

@jdkent
Copy link
Contributor Author

jdkent commented Sep 23, 2020

looks like my pull request does not have access to the same environmental variables as builds on master have resulting in some tests being skipped. Is this on purpose to ensure API call limits do not go over?

@adelavega
Copy link
Member

Yes, the API tests are not being run on PRs.

I usually will test these locally once I think I'm close. You could do the same if you get some Google keys (there should be a free tier in the meantime).

@jdkent
Copy link
Contributor Author

jdkent commented Sep 23, 2020

Thanks for the clarification, is this where I get some google keys?

Always wanted to take a google on a test drive

@adelavega
Copy link
Member

yep! just get some there and put them in the environment

@adelavega
Copy link
Member

I tested this and it fixes the regression. Will merge, but I also noticed there's a lot more regressions w/ Google API that need to be looked into.

@adelavega adelavega merged commit 9d9b126 into PsychoinformaticsLab:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants