Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove --no-user-group #414

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Sep 11, 2020

closes #413

@adelavega
Copy link
Member

I don't know why that is in the original Dockerfile but I would say if you are able to get it to build, and get all the tests to pass within the container, it should be OK

@jdkent
Copy link
Contributor Author

jdkent commented Sep 11, 2020

Could you try rebuilding master? There are a few failures that are not immediately obvious to me as to why this Dockerfile edit would make them fail.

@adelavega
Copy link
Member

I wonder why travis is not showing up here... it also doesn't seem to think i have those privileges

@adelavega
Copy link
Member

They're probably not related to the Dockerfile change, I'll open another PR with just a trivial change to trigger a build.

@adelavega
Copy link
Member

@jdkent
Copy link
Contributor Author

jdkent commented Sep 11, 2020

One thing that's presumably causing the AttributeError: module 'yamnet' has no attribute 'params' error is this line, I'll change the url to a release the represents the code when it was working.

@adelavega
Copy link
Member

that actually failed for me recently in neuroscout so that explains it

@jdkent
Copy link
Contributor Author

jdkent commented Sep 23, 2020

Now that the unrelated test failures have been addressed, does this pull request look okay?

@adelavega
Copy link
Member

LGTM

@adelavega adelavega merged commit 1aec4e8 into PsychoinformaticsLab:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile: chown group error
2 participants