keep backup of datastore file, to help recover from corruption #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-p
force-pushed
the
datastore-backup
branch
2 times, most recently
from
0919282 to
9d356a7
Compare
We have seen data corruption in user feedback (usually in the form of JSON parsing failing, but sometimes in the form of impossible data values, we think). We can't be certain that this is due to file corruption, but it's certainly possible that out of millions of users, some will have file corruption issues each day. We believe (and hope) that having a backup datastore file brings that probability down greatly -- two files need to suffer the same improbable event at the same time.
adam-p
force-pushed
the
datastore-backup
branch
from
9d356a7 to
48df0a9
Compare
So the test GitHub Action will run for PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen data corruption in user feedback (usually in the form of JSON parsing failing, but sometimes in the form of impossible data values, we think). We can't be certain that this is due to file corruption, but it's certainly possible that out of millions of users, some will have file corruption issues each day. We believe (and hope) that having a backup datastore file brings that probability down greatly -- two files need to suffer the same improbable event at the same time.
The upgrade for users should be seamless. (And even downgrading should work, although it's not explicitly supported.)