Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Model Anomaly + Subroutine Framework #14

Merged
merged 27 commits into from
May 4, 2023

Conversation

Elscrux
Copy link
Member

@Elscrux Elscrux commented Apr 10, 2023

No description provided.

@Elscrux Elscrux requested a review from schweikart April 10, 2023 14:09
@Elscrux
Copy link
Member Author

Elscrux commented Apr 21, 2023

@schweikart Thank you for the review, I've pushed a lot of tweaks

@Elscrux
Copy link
Member Author

Elscrux commented May 3, 2023

Everything should be ready now @schweikart :)

@Elscrux
Copy link
Member Author

Elscrux commented May 3, 2023

Oh, that's probably my bad.

SolverSelection would be more common as you can use these components just like any other:

<SolverSelection/> instead of getSolvers() (line 66)

One more thing:
This actually seems to cause problems! It resets the selection every time I try to select an option. Do you know what could cause this?

@Elscrux
Copy link
Member Author

Elscrux commented May 3, 2023

export type SolveMap = {
[key: string]: SolveRequest
}
maybe use a Map instead? This typing will set all attributes of SolveMap instances to be SolveRequests but toString and other built-in attributes / functions are not SolveMaps!

I had a problem with Map<K,V> in the past, so I used this, but I can't replicate it now, so I'll use that instead.

I actually replicate the issue now. As Map<K, V> is an object, it gets formatted differently in the JSON that is sent to the backend.
The backend can't properly parse this format to a Java Map.

Copy link
Member

@schweikart schweikart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@schweikart schweikart changed the base branch from main to develop May 4, 2023 13:50
@schweikart schweikart merged commit df0b5d3 into develop May 4, 2023
@schweikart schweikart deleted the feature-model/anomaly branch May 4, 2023 13:51
@schweikart schweikart mentioned this pull request Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants