[refactor] Improve the Display impl for ProgramCore #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
reviewed
Aug 24, 2024
vicsn
approved these changes
Aug 24, 2024
zosorock
requested review from
evanmarshall,
fulltimemike,
zkxuerb,
zklimaleo and
a team
|
The same CI jobs have failed 3 times. @vicsn can you let us know if you feel these are relevant or not, please? |
|
Merging upstream should do the trick for The parameters test is unrelated, not sure why it fails, will look into it if it becomes a recurring problem. |
|
@vicsn sure, I'll rebase shortly 👌 |
Signed-off-by: ljedrz <[email protected]>
ljedrz
force-pushed
the
refactor/display_programcore
branch
from
c7e8686 to
93b4aca
Compare
gluax
approved these changes
Oct 29, 2024
alzger
requested review from
gluax,
Meshiest,
lukenewman,
asharma13524 and
voximity
gluax
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a refactoring, but with some performance implications; this impl also shouldn't cause a panic anymore in case of a formatting error.
Found via fuzzing, with
Stack::newcausing multiple crashes during the parse check.