Updating Canary genesis block with TransmissionID checksum - v0.4.0 #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2541) Signed-off-by: Fabiano <[email protected]>
Signed-off-by: Fabiano <[email protected]>
zosorock
requested review from
evanmarshall,
ljedrz,
niklaslong,
aleojohn,
zkxuerb and
a team
zosorock
changed the title
raychu86
previously approved these changes
Jul 30, 2024
There was a problem hiding this comment.
LGTM, though I'm not sure I like having the JSON objects because all of the information already exists in block.genesis.
It is another surface that will need to be updated if block.genesis needs to be resampled, and this feels easy to forget down the line.
In the context of this PR, it's obvious that these files were used to create the genesis block, however it isn't clear from an outside perspective. At the least, I think a name change is warranted; for example, validators.json -> genesis_validators.json
Meshiest
previously approved these changes
Jul 30, 2024
Signed-off-by: Fabiano <[email protected]>
aleojohn
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updating to Canary genesis block v0.4.0
sha256 == e6419d92fa653a9560310a168ac2f3c65cb3edc9ffb966e1fdb1d208bc0929d2Related PRs
#2521
ProvableHQ/snarkOS#3367