[Test] Execution cost. #2379
Merged
[Test] Execution cost. #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
reviewed
Mar 8, 2024
synthesizer/process/src/cost.rs
Outdated
Comment on lines
25
to
36
| const CAST_BASE_COST: u64 = 500; | ||
| const CAST_PER_BYTE_COST: u64 = 30; | ||
| const HASH_BASE_COST: u64 = 10_000; | ||
| const HASH_PER_BYTE_COST: u64 = 30; | ||
| const HASH_BHP_BASE_COST: u64 = 50_000; | ||
| const HASH_BHP_PER_BYTE_COST: u64 = 300; | ||
| const HASH_PSD_BASE_COST: u64 = 40_000; | ||
| const HASH_PSD_PER_BYTE_COST: u64 = 75; | ||
| const MAPPING_BASE_COST: u64 = 10_000; | ||
| const MAPPING_PER_BYTE_COST: u64 = 10; | ||
| const SET_BASE_COST: u64 = 10_000; | ||
| const SET_PER_BYTE_COST: u64 = 100; |
|
Why does this PR touch non-test code? |
howardwu
reviewed
Mar 20, 2024
Signed-off-by: Howard Wu <[email protected]>
howardwu
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on #2369 with two tests checking that the finalize cost is calculated correctly.
The finalize cost of an execution is the finalize cost of its root transition.
This should be equal to the sum of the cost of all commands in each finalize block in each transition in the execution.
As a by product, this PR also refactors the cost utilities to support
command_costwhich returns the cost of a command.