Abort transactions with already spent InputIDs

[raychu86]

Motivation

This PR adds logic to VM::atomic_speculate to track spent InputIDs and abort transactions that attempt to spend an InputID that was already spent in this block.

Note: We may want to use the InputStore::get_speculative instead of per block trackers in atomic_speculate.

Related to: https://github.com/AleoHQ/snarkOS/pull/2852

Test Plan

A test has been added to check that the possible double spends are caught and aborted.

[ghostant-1017]

It seems check at atomic_speculate is needless, we've already checked at check_next_block https://github.com/AleoHQ/snarkVM/blob/testnet3/ledger/block/src/verify.rs#L416

[raychu86]

It seems check at atomic_speculate is needless, we've already checked at check_next_block https://github.com/AleoHQ/snarkVM/blob/testnet3/ledger/block/src/verify.rs#L416

The logic change in atomic_speculate is not just a check, as it fully aborts subsequent transactions with spent InputIDs before creating a block. The check in check_next_block is to validate that the final block is well-formed.

[ghostant-1017]

It seems check at atomic_speculate is needless, we've already checked at check_next_block https://github.com/AleoHQ/snarkVM/blob/testnet3/ledger/block/src/verify.rs#L416

The logic change in atomic_speculate is not just a check, as it fully aborts subsequent transactions with spent InputIDs before creating a block. The check in check_next_block is to validate that the final block is well-formed.

Thank you for explanation! I misunderstood it.