[NCC-EVJ] Use Committee stakes when determining the timestamp of a Subdag
#2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
reviewed
Dec 5, 2023
Comment on lines
+87
to
+90
| #[cfg(not(feature = "serial"))] | ||
| timestamps_and_stake.par_sort_unstable_by_key(|(timestamp, _)| *timestamp); | ||
| #[cfg(feature = "serial")] | ||
| timestamps_and_stake.sort_unstable_by_key(|(timestamp, _)| *timestamp); |
There was a problem hiding this comment.
You could make another one of these macros, more in line with existing code (I only know it from the algorithms crate)
ljedrz
reviewed
Dec 27, 2023
randomsleep
reviewed
Jan 8, 2024
randomsleep
reviewed
Jan 8, 2024
| timestamps[timestamps.len() / 2] | ||
| // Retrieve the timestamps and stakes of the certificates. | ||
| let timestamps_and_stakes = self | ||
| .values() |
There was a problem hiding this comment.
Should we use the median of leader_certificate's parents or all certificates? It makes no sense to use the weighted median of all certificates.
howardwu
reviewed
Jan 18, 2024
Signed-off-by: Howard Wu <[email protected]>
howardwu
approved these changes
Jan 19, 2024
raychu86
changed the title
Committee stakes when determining the timestamp of a SubdagCommittee stakes when determining the timestamp of a Subdag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the
Subdag::timestampfunction from a simple median timestamp to a weighed median timestamp that uses the committee member stakes as the weights.Because quorum is determined by stake and not the number of validators, we must also use stake to determine the timestamp.
Audit Finding: [NCC EVJ] Timestamp Calculation Does Not Provide Byzantine Fault Tolerance