-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Optimize] Right shift. #2052
Merged
howardwu
merged 4 commits into
tracking/circuit-optimizations-and-fixes
from
optimize/shr
Oct 14, 2023
Merged
[Optimize] Right shift. #2052
howardwu
merged 4 commits into
tracking/circuit-optimizations-and-fixes
from
optimize/shr
Oct 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoglio
reviewed
Oct 11, 2023
acoglio
reviewed
Oct 11, 2023
acoglio
reviewed
Oct 11, 2023
acoglio
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo the comments given.
59429b5
to
2e4926b
Compare
Co-authored-by: Alessandro Coglio <[email protected]> Signed-off-by: d0cd <[email protected]>
Co-authored-by: Alessandro Coglio <[email protected]> Signed-off-by: d0cd <[email protected]>
Base automatically changed from
optimize/shl
to
tracking/circuit-optimizations-and-fixes
October 14, 2023 02:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes right shifts for all integers except for
i/u128
.This PR depends on #2050