Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize] Right shift. #2052

Merged
merged 4 commits into from
Oct 14, 2023

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Oct 7, 2023

This PR optimizes right shifts for all integers except for i/u128.

This PR depends on #2050

@d0cd d0cd marked this pull request as ready for review October 10, 2023 18:30
@d0cd d0cd requested review from acoglio, bendyarm and howardwu October 10, 2023 18:30
Copy link
Contributor

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo the comments given.

@d0cd d0cd force-pushed the tracking/circuit-optimizations-and-fixes branch from 59429b5 to 2e4926b Compare October 13, 2023 21:04
@d0cd d0cd changed the base branch from tracking/circuit-optimizations-and-fixes to optimize/shl October 13, 2023 21:11
Base automatically changed from optimize/shl to tracking/circuit-optimizations-and-fixes October 14, 2023 02:20
@howardwu howardwu merged commit 9ef233c into tracking/circuit-optimizations-and-fixes Oct 14, 2023
@howardwu howardwu deleted the optimize/shr branch October 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants