[Fix] Square root #2049
Merged
[Fix] Square root #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoglio
approved these changes
Oct 10, 2023
d0cd
force-pushed
the
tracking/circuit-optimizations-and-fixes
branch
from
59429b5 to
2e4926b
Compare
d0cd
force-pushed
the
fix/non-det-in-sqrt
branch
from
e304c9d to
23763ac
Compare
d0cd
changed the base branch from
tracking/circuit-optimizations-and-fixes
to
fix/cast-field-to-group
Base automatically changed from
fix/cast-field-to-group
to
tracking/circuit-optimizations-and-fixes
October 14, 2023 03:02
Pratyush
reviewed
Oct 14, 2023
| assert_eq!((88514, 130701, 83646), assignment.num_nonzeros()); | ||
| assert_eq!(55698, assignment.num_private()); | ||
| assert_eq!(55761, assignment.num_constraints()); | ||
| assert_eq!((90368, 132045, 84980), assignment.num_nonzeros()); |
There was a problem hiding this comment.
This pushes us to the next power of two here (2^18, as opposed to 2^17)
There was a problem hiding this comment.
Great catch, I didn't notice that, thank you!
There was a problem hiding this comment.
I've addressed the imbalance with this PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a non-determinism issue in the square root circuit by ensuring that that result is less than (p - 1)/2, where p is the field modulus.
Note: this PR affects the
elligator2::encodecircuit. If determinism is not needed, we should consider adding asquare_root_uncheckedcircuit.This PR depends on #2072