[Optimize] Unsigned checked addition #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoglio
reviewed
Oct 11, 2023
acoglio
reviewed
Oct 11, 2023
acoglio
reviewed
Oct 11, 2023
acoglio
approved these changes
Oct 12, 2023
d0cd
force-pushed
the
tracking/circuit-optimizations-and-fixes
branch
from
59429b5 to
2e4926b
Compare
d0cd
force-pushed
the
optimize/add-checked
branch
from
f2fc4d2 to
a1948e2
Compare
d0cd
changed the base branch from
tracking/circuit-optimizations-and-fixes
to
optimization/mul-checked
Merged
Base automatically changed from
optimization/mul-checked
to
tracking/circuit-optimizations-and-fixes
October 14, 2023 02:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes unsigned checked addition by directly witnessing the product and checking that the sum and witness match in the base field.
This PR depends on #2047