Skip to content

Commit

Permalink
Merge pull request #2160 from AleoHQ/fix/fee-off-by-one
Browse files Browse the repository at this point in the history 
[TOB] Fix off-by-one `N::MAX_FEE` check
  • Loading branch information
@howardwu
howardwu authored Nov 10, 2023
2 parents e88b8fa + b73ad56 commit 72b22b0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion synthesizer/src/vm/verify.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ impl<N: Network, C: ConsensusStorage<N>> VM<N, C> {

// Ensure the fee does not exceed the limit.
let fee_amount = fee.amount()?;
ensure!(*fee_amount < N::MAX_FEE, "Fee verification failed: fee exceeds the maximum limit");
ensure!(*fee_amount <= N::MAX_FEE, "Fee verification failed: fee exceeds the maximum limit");

// Verify the fee.
let verification = self.process.read().verify_fee(fee, deployment_or_execution_id);
Expand Down

1 comment on commit 72b22b0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'snarkVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 72b22b0 Previous: 320ac64 Ratio
VariableBase MSM on BLS12-377 (10000) 101079426 ns/iter (± 1843933) 65947946 ns/iter (± 1286576) 1.53
VariableBase MSM on BLS12-377 (100000) 701590228 ns/iter (± 10785607) 433117138 ns/iter (± 7857770) 1.62
VariableBase MSM on BLS12-377 (200000) 1323797575 ns/iter (± 56190287) 813967850 ns/iter (± 7517197) 1.63
VariableBase MSM on BLS12-377 (300000) 2013500438 ns/iter (± 38172483) 1256839103 ns/iter (± 2427303) 1.60
VariableBase MSM on BLS12-377 (400000) 2554161211 ns/iter (± 47510612) 1583795196 ns/iter (± 1829207) 1.61
VariableBase MSM on BLS12-377 (500000) 2864098300 ns/iter (± 45577963) 1776369745 ns/iter (± 7742188) 1.61
VariableBase MSM on BLS12-377 (1000000) 5200145544 ns/iter (± 84434243) 3281678968 ns/iter (± 9677482) 1.58
VariableBase MSM on BLS12-377 (2000000) 9422612836 ns/iter (± 104152563) 5758980986 ns/iter (± 28574162) 1.64
Variable MSM on Edwards-BLS12 (100000) 404106293 ns/iter (± 9165752) 252800817 ns/iter (± 647630) 1.60
Variable MSM on Edwards-BLS12 (1000000) 3483366534 ns/iter (± 53027185) 2221422138 ns/iter (± 17990293) 1.57
LinearCombination::add_assign 489156 ns/iter (± 12902) 299202 ns/iter (± 5811) 1.63
debug 785682675 ns/iter (± 22890612) 389873659 ns/iter (± 5219053) 2.02
Poseidon4 Hash 10 -> 4 189603 ns/iter (± 10021) 122860 ns/iter (± 3606) 1.54
Poseidon8 Hash 4 -> 1 210718 ns/iter (± 10363) 128472 ns/iter (± 239) 1.64
Poseidon8 Hash 4 -> 2 200985 ns/iter (± 7935) 128589 ns/iter (± 3792) 1.56
Poseidon8 Hash 10 -> 1 317648 ns/iter (± 8491) 193652 ns/iter (± 3801) 1.64
Poseidon8 Hash 10 -> 4 305399 ns/iter (± 14979) 193788 ns/iter (± 262) 1.58
Poseidon8 Hash 10 -> 8 304352 ns/iter (± 12369) 193812 ns/iter (± 1567) 1.57
MerkleTree/new/10000 1127412272 ns/iter (± 30941028) 714618704 ns/iter (± 8002394) 1.58
MerkleTree/new/100000 9538828397 ns/iter (± 119587307) 6108363152 ns/iter (± 16448057) 1.56
MerkleTree/append/1/10000 1102347802 ns/iter (± 15320930) 712959110 ns/iter (± 7513670) 1.55
MerkleTree/append/1/100000 9482206099 ns/iter (± 116902706) 6095768015 ns/iter (± 28344570) 1.56
MerkleTree/append/10/1000 94098859 ns/iter (± 3482217) 59742921 ns/iter (± 115799) 1.58
MerkleTree/append/10/10000 1108953548 ns/iter (± 27260350) 710635631 ns/iter (± 8331415) 1.56
MerkleTree/append/10/100000 9488457710 ns/iter (± 104127840) 6074017235 ns/iter (± 32811995) 1.56
MerkleTree/append/100/1000 133423982 ns/iter (± 2115403) 86842533 ns/iter (± 444471) 1.54
MerkleTree/append/100/10000 1133419548 ns/iter (± 26018460) 708581753 ns/iter (± 2001608) 1.60
MerkleTree/append/100/100000 9520722305 ns/iter (± 126017427) 6073476553 ns/iter (± 23042393) 1.57
MerkleTree/append/1000/1000 92585924 ns/iter (± 3518706) 61291943 ns/iter (± 436103) 1.51
MerkleTree/append/1000/10000 1061576533 ns/iter (± 24420985) 680729815 ns/iter (± 2470548) 1.56
MerkleTree/append/1000/100000 9462551181 ns/iter (± 121679768) 6050148079 ns/iter (± 18270670) 1.56
MerkleTree/append/10000/1000 91544841 ns/iter (± 1536320) 59940258 ns/iter (± 54454) 1.53
MerkleTree/append/10000/10000 1426764829 ns/iter (± 39078382) 902804523 ns/iter (± 4446911) 1.58
MerkleTree/append/10000/100000 8970180371 ns/iter (± 116854060) 5785313164 ns/iter (± 20913794) 1.55
MerkleTree/append/100000/1000 97949543 ns/iter (± 3506600) 63294590 ns/iter (± 1853058) 1.55
MerkleTree/append/100000/10000 829485549 ns/iter (± 39274267) 528641181 ns/iter (± 8212463) 1.57
MerkleTree/append/100000/100000 11000593964 ns/iter (± 128354156) 7017857008 ns/iter (± 40532696) 1.57
MerkleTree/update_many/1000/1000 90383322 ns/iter (± 3131081) 59484358 ns/iter (± 469032) 1.52
MerkleTree/update_many/1000/1000 #2 89529399 ns/iter (± 3753850) 59509989 ns/iter (± 298398) 1.50
MerkleTree/update_many/100000/1000 180964896 ns/iter (± 2494374) 119220818 ns/iter (± 1223309) 1.52
MerkleTree/update_many/100000/10000 1699533148 ns/iter (± 50195204) 1107692031 ns/iter (± 2251524) 1.53
bls12_377: fq_repr_mul2 5 ns/iter (± 0) 3 ns/iter (± 0) 1.67
bls12_377: fq_repr_div2 5 ns/iter (± 0) 3 ns/iter (± 0) 1.67
bls12_377: fq12_add_assign 211 ns/iter (± 8) 114 ns/iter (± 3) 1.85
bls12_377: fq12_sub_assign 123 ns/iter (± 6) 61 ns/iter (± 0) 2.02
bls12_377: fq12_double 121 ns/iter (± 4) 64 ns/iter (± 0) 1.89
bls12_377: fr_repr_add_nocarry 5 ns/iter (± 0) 3 ns/iter (± 0) 1.67
bls12_377: fr_repr_sub_noborrow 5 ns/iter (± 0) 3 ns/iter (± 0) 1.67
bls12_377: fr_sub_assign 5 ns/iter (± 0) 3 ns/iter (± 0) 1.67
Block::to_string (serde_json) 318715 ns/iter (± 11030) 212247 ns/iter (± 378) 1.50
Header::to_bytes_le 386 ns/iter (± 12) 238 ns/iter (± 3) 1.62
Header::serialize (bincode) 758 ns/iter (± 30) 485 ns/iter (± 1) 1.56

This comment was automatically generated by workflow using github-action-benchmark.

CC: @raychu86

Please sign in to comment.