Reorganization of the InterPro Scan Search results section #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teinsWebTeam/interpro7-client into reorganization_interpro_scan
apolignano
changed the title
matthiasblum
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Thanks, it looks very nice.
Here are a few things to fix:
- tooltips should include the InterPro accession for integrated signatures, like the domain viewer for protein pages.
- the short name of InterPro entries and member database signatures are not displayed in the table (in the "Entries" tab)
Also, it would be nice to simply hide the "Unintegrated" section (not even show the title) if there are no tracks inside.
Finally, while it's not that important and not in the scope of this PR, I noticed there is a trailing zero below the sequence in the "Sequence" tab (see screenshot). Can you check where it's coming from and delete it?
src/components/Related/DomainsOnProtein/DomainsOnProteinLoaded/index.tsx
Show resolved
Hide resolved
matthiasblum
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.