Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikipedia links for clans #687

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Wikipedia links for clans #687

merged 3 commits into from
Jan 24, 2025

Conversation

apolignano
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Coverage Status

coverage: 18.52%. remained the same
when pulling 8e886de on clan_wikipedia
into dbff908 on dev.

Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move the Wikipedia section above the clan viewer?
Also, could you edit the ClanViewer component so a title is displayed before the viewer itself (like the Wikipedia section starts with <h4>Wikipedia</h4>)?

Thanks

@apolignano apolignano merged commit 10c3a0e into dev Jan 24, 2025
3 checks passed
@matthiasblum matthiasblum deleted the clan_wikipedia branch February 7, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants