Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts EntryMenu #587

Closed
wants to merge 4 commits into from
Closed

Ts EntryMenu #587

wants to merge 4 commits into from

Conversation

gustavo-salazar
Copy link
Member

Migrating to TS:

  • EntryMenu
  • EntryMenuLink

Extracting to migrate

  • EntryMenuLinkWithoutData

Type changes

The values in an InterProLocation's Endpoint can be null, as that's how we have them in the redux state. For example customLocation.description.entry.accession can be null in browse pages.
Multiple files needed an update in order to adjust to that change.

@coveralls
Copy link

coveralls commented Feb 23, 2024

Coverage Status

coverage: 23.664% (-0.2%) from 23.828%
when pulling ccb77a9 on ts-has-alphafold
into 3b1cc90 on has-alphafold.

Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

['Alignments', { icon: '\uF1DE', class: 'icon-common' }],
['Sequence', { icon: '\uF120', class: 'icon-common' }],
['Curation', { icon: undefined, class: 'icon-common' }],
['New Structural Model', { icon: undefined, class: 'icon-common' }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot this item be removed?

@gustavo-salazar gustavo-salazar deleted the branch has-alphafold March 4, 2024 10:27
@gustavo-salazar gustavo-salazar mentioned this pull request Mar 4, 2024
@gustavo-salazar gustavo-salazar deleted the ts-has-alphafold branch March 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants