Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIFT mapping #546

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Fix SIFT mapping #546

merged 4 commits into from
Nov 28, 2023

Conversation

matthiasblum
Copy link
Contributor

This PR fixes the representation of structure chains on the protein viewer.

Examples:

@coveralls
Copy link

coveralls commented Nov 28, 2023 •
edited
Loading

Coverage Status

coverage: 23.594%. remained the same
when pulling 92d087d on fix-structure-on-protein
into e61dc74 on master.

@matthiasblum matthiasblum changed the base branch from dev to master November 28, 2023 15:22
gustavo-salazar
gustavo-salazar approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@gustavo-salazar gustavo-salazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes.

I also added a commit to update molstar, which fixes a couple of cases where the structure was not been displayed. e.g. 3au5 8tzp

please give it a try before merging

@matthiasblum matthiasblum merged commit 163e7dd into master Nov 28, 2023
@matthiasblum matthiasblum deleted the fix-structure-on-protein branch December 4, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-salazar gustavo-salazar gustavo-salazar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiasblum @coveralls @gustavo-salazar