Release 97.0 #526
Release 97.0 #526
Conversation
# Conflicts: # src/components/Entry/Summary/index.tsx # src/custom.d.ts
Removed signatures
# Conflicts: # src/components/Entry/Summary/SidePanel/index.tsx
AI-generated descriptions
Pfam helpdesk
Pfam set/clan terminology
Use pre-selected representative domains
Fix endpoint page loading
| text: string; | ||
| }; | ||
|
|
||
| class DescriptionLLM extends PureComponent<Props> { |
There was a problem hiding this comment.
Nothing wrong with it, but wondering why do you prefer PureComponent here instead of a functional component?
There was a problem hiding this comment.
I believe I based the component on the Description one which extends PureComponent.
There was a problem hiding this comment.
Right back at me!! 🤦🏽♂️
|
|
||
| return ( | ||
| <> | ||
| <div className={css('row')}> |
There was a problem hiding this comment.
OK for now, but my idea of the migration towards the visual framework and out of foundation, also includes not using the column/row strategy but rather flex, grid or other layouts available directly in CSS.
I'll put a note on this and will change the classes later when working on the TS migration.
There was a problem hiding this comment.
Good point. I went for the simplest solution, but indeed this needs to be changed for a better layout system.
| /> | ||
| </> | ||
| ); | ||
| } else if (metadata.integrated) { |
There was a problem hiding this comment.
So a description from the integrated signature is preferred over one AI generated?
There was a problem hiding this comment.
Yes. Right now, we don't have any integrated signature with AI-generated descriptions, but if we ever have these cases we should prioritise descriptions provided by member databases (unless we have evidence that AI-generated descriptions are better).
| @@ -10,6 +10,14 @@ | |||
| margin: 4px; | |||
| z-index: var(--z-index-tooltips); | |||
|
|
|||
| &.fixed { | |||
There was a problem hiding this comment.
was this trying to fix the overgrown tooltip? is it still necessary after my fix?
There was a problem hiding this comment.
Yes. Feel free to remove it now that your fix addresses the overgrown tooltip.
| @@ -45,6 +48,14 @@ const Tooltip = ({ | |||
| arrow({ | |||
| element: arrowRef, | |||
| }), | |||
| size({ | |||
There was a problem hiding this comment.
@matthiasblum this is how I'm trying to solve the issue about the overgrown tooltip. It seems to work well here and in other cases , but let me know if you notice the tooltip misbehaving somewhere else
Includes the following changes:
representativeboolean property returned by the API Use pre-selected representative domains #525