-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightingale v4 #458
Nightingale v4 #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
Only one thing that I think needs to be changed: a reference to protvista-colored-sequence
const element = detail?.target?.closest('protvista-colored-sequence'); |
I saw that we depend on draft-js
for the text box used to search sequences. Would it be possible to use Nightingale's textarea-sequence
instead in the future?
Yes, thatwas the motivation to work on migrating |
Co-authored-by: Matthias Blum <[email protected]>
Co-authored-by: Matthias Blum <[email protected]>
Co-authored-by: Matthias Blum <[email protected]>
removing legacy bundle
All the changes required to use Nightingale components v4. The components/pages were the changes are relevant:
Changes include:
snake-case
d3
was removed as a general dependency and only keptd3-scale
because of its use of mapping coordinates between structure, protein and entries.flow-typed
sorry for the noise :-)NOTE: I'll move this from draft to an actual PR when all the PRs in nightingale get resolved. and components are published on full version and not
alpha