Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightingale v4 #458

Merged
merged 36 commits into from
Apr 12, 2023
Merged

Nightingale v4 #458

merged 36 commits into from
Apr 12, 2023

Conversation

gustavo-salazar
Copy link
Member

@gustavo-salazar gustavo-salazar commented Feb 14, 2023

All the changes required to use Nightingale components v4. The components/pages were the changes are relevant:

  • Any protein viewer(e.g. protein, structure and model, interproscan)
  • Sunburst view of the taxonomy
  • Pfam alignments subpage
  • Rossetta model pages have the multiple components interacting(heatmap, contacts, msa, navigation, and molstar)

Changes include:

  • installing the new components from @nightingale-elements namespace in npm.
  • All attributes are now snake-case
  • d3 was removed as a general dependency and only kept d3-scale because of its use of mapping coordinates between structure, protein and entries.
  • Most files changed correspond to updates on flow-typed sorry for the noise :-)
  • dependencies updates.

NOTE: I'll move this from draft to an actual PR when all the PRs in nightingale get resolved. and components are published on full version and not alpha

@coveralls
Copy link

coveralls commented Feb 14, 2023

Coverage Status

Coverage: 21.068% (+0.02%) from 21.047% when pulling e8be7b4 on nightingaleV4 into a69a90c on dev.

@gustavo-salazar gustavo-salazar marked this pull request as ready for review March 22, 2023 15:07
Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

Only one thing that I think needs to be changed: a reference to protvista-colored-sequence

const element = detail?.target?.closest('protvista-colored-sequence');

I saw that we depend on draft-js for the text box used to search sequences. Would it be possible to use Nightingale's textarea-sequence instead in the future?

@gustavo-salazar
Copy link
Member Author

I saw that we depend on draft-js for the text box used to search sequences. Would it be possible to use Nightingale's textarea-sequence instead in the future?

Yes, thatwas the motivation to work on migrating textarea-sequnce at this stage. Draft.js has been deprecated, while Quill.js is still on active development

@gustavo-salazar gustavo-salazar merged commit a6d59a7 into dev Apr 12, 2023
@matthiasblum matthiasblum deleted the nightingaleV4 branch September 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants