Skip to content

Update CODEOWNERS to better reflect reality #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

dopplershift
Copy link
Contributor

No description provided.

@dopplershift dopplershift requested a review from a team as a code owner September 23, 2021 18:16
@dopplershift
Copy link
Contributor Author

Looks like this one is having the weird "leave the team assigned" issue. I wonder if it has to do with having multiple teams assigned to /content/ in the current file?

@dopplershift dopplershift removed the request for review from a team September 23, 2021 18:21
@dopplershift
Copy link
Contributor Author

Ok, actually the persistence of the team was due to main being a protected branch which required a review from codeowners. Per the docs:

When code owners are automatically requested for review, the team is still removed and replaced with individuals. The individual approvals don't satisfy the requirement for code owner approval in a protected branch.

So I have disabled the required review from codeowners for now. I can re-enable if we decide otherwise, but this should solve the "team stays assigned" problem.

@brian-rose brian-rose merged commit 4c700ab into ProjectPythia:main Sep 23, 2021
@dopplershift dopplershift deleted the update-codeowners branch September 23, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants