-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prettier from pre-commit #174
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Other repos that suffer from the same issue include
|
@dopplershift are you aware of any issue tracking the problem with pre-commit and prettier releases that we can link here? It would be great to get the functionality of prettier back once the headaches are resolved. |
Let's just say upstream is less than interested about doing anything about this. "Working as intended" was one phrase I saw. 🙄 |
For the record, an attitude like that from upstream (not the first time I've seen it) has me reconsidering future use of pre-commit in my projects. |
Good to know that there's essentially zero chance of an upcoming change in how pre-commit handles these cases. Are we happy with the compromise of just removing prettier from the pre-commit list, and thus losing its functionality? Here and in several other of our repos? |
There might be a viable alternative: keep using prettier, but exclude it from auto-updates (and thus need to manually update its version in If I'm interpreting these docs correctly, we should be able to do this just by adding this block to
@dopplershift does that sound correct? |
@brian-rose My read of those docs implies that this will only skip running prettier on the pre-commit CI service, not disable updating the version. I can find no way to dial back updates, only ways to store hashes for versions or use "bleeding edge": https://pre-commit.com/#pre-commit-autoupdate |
@dcamron and I have also found that currently precommit-ci is only set to run on 7 of our own repositories, not any of the cookbook repos (and currently that list would have to be added to manually rather than having "all repositories" set). I think we need to think a little more about what we want the user experience to be, both locally and on GitHub. |
Closes #186 |
As suggested by @dopplershift, due to the continued aggravation of pre-commit opening PRs that include pre-release alpha versions of prettier, this PR just removes prettier entirely from our pre-commit config.