Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 2 package dependencies #1660

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

tangy5
Copy link
Collaborator

@tangy5 tangy5 commented Mar 27, 2024

multipart 0.0.9
fastapi==0.110.0

@tangy5
Copy link
Collaborator Author

tangy5 commented Mar 27, 2024

Hi @SachidanandAlle , can you help tag a MONAILabel 0.8.1 version to enable the new monaitoolkit release, thank you!
:)

@tangy5 tangy5 requested a review from SachidanandAlle March 27, 2024 21:05
tangy5 added 4 commits March 27, 2024 14:24
Signed-off-by: tangy5 <[email protected]>
Signed-off-by: tangy5 <[email protected]>
Signed-off-by: tangy5 <[email protected]>
Signed-off-by: tangy5 <[email protected]>
@tangy5
Copy link
Collaborator Author

tangy5 commented Mar 27, 2024

We are getting an error from packaging dicom-client GCP, @SachidanandAlle , do you have any idea?

  File "/home/runner/work/MONAILabel/MONAILabel/monailabel/app.py", line 23, in <module>
    from monailabel.endpoints import (
  File "/home/runner/work/MONAILabel/MONAILabel/monailabel/endpoints/activelearning.py", line 20, in <module>
    from monailabel.interfaces.app import MONAILabelApp
  File "/home/runner/work/MONAILabel/MONAILabel/monailabel/interfaces/app.py", line 31, in <module>
    from dicomweb_client.ext.gcp.session_utils import create_session_from_gcp_credentials
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/dicomweb_client/ext/gcp/session_utils.py", line 8, in <module>
    raise ImportError(
ImportError: The `dicomweb-client` package needs to be installed with the "gcp" extra requirements to use this module, as follows: `pip install dicomweb-client[gcp]`

@SachidanandAlle
Copy link
Collaborator

Check locally on a new pip venv to debug the dependency issue

@SachidanandAlle
Copy link
Collaborator

can you resolve conflicts and try again..

add your changes to both requirements.txt and
https://github.com/Project-MONAI/MONAILabel/blob/main/setup.cfg#L37-L70

@SachidanandAlle SachidanandAlle enabled auto-merge (squash) April 2, 2024 18:27
@SachidanandAlle SachidanandAlle merged commit 4dda1bb into Project-MONAI:main Apr 2, 2024
14 checks passed
@tangy5 tangy5 deleted the update_dependencies branch April 2, 2024 18:34
@SachidanandAlle
Copy link
Collaborator

0.8.2rc1 will be created and pushed.. @tangy5 u can test and verify all is ok.. and then we can push the final tag for 0.8.2
https://github.com/Project-MONAI/MONAILabel/actions/runs/8528081530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants