Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified videodataset for window multiprocessing #8323

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

JK-rez
Copy link

@JK-rez JK-rez commented Feb 2, 2025

Fixes #8322

Description

Slight workaround to VideoCapure behaviours when num worker > 0 in dataloader.
Explicitly assign video capture object to release if after reading frame. Should prevent deadlock and other cv2 errors from occurring.
Not tested exhaustively as current pipelines in CV for video pre process videos into frame beforehand. Current dataclass not scalable

Types of changes

  • [] Non-breaking change (fix or new feature that would not break existing functionality).
  • [x ] Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@ericspod ericspod self-requested a review February 2, 2025 20:26
@ericspod
Copy link
Member

ericspod commented Feb 4, 2025

Thanks for the update. Could we add a test to capture this issue somehow? The problem seems to be multiprocessing in Windows from what we discussed, can we add a unit test using multiprocessing to ensure this works in Windows and elsewhere? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VideoDataset Deadlock and error
2 participants