5935 fixes spacing pixdim inplace change

[wyli]

Signed-off-by: Wenqi Li [email protected]

Fixes #5935

Description

assigning out_d[idx] in the __call__ shouldn't change self.pixdim in Spacing

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[wyli]

/build

[wyli]

/build

[myron]

I struggled to find this bug for many hours in monai1.1
Spacing / Resampling transform changed the resolution randomly , in my case when using min_pixdim, max_pixdim, and Dataloader with several workers, each worker can potentially change the self.pixdim, and next image gets wrong result...
Thanks for fixing it.

[wyli]

I struggled to find this bug for many hours in monai1.1 Spacing / Resampling transform changed the resolution randomly , in my case when using min_pixdim, max_pixdim, and Dataloader with several workers, each worker can potentially change the self.pixdim, and next image gets wrong result... Thanks for fixing it.

Thanks for reporting. I hope there's a method to document recent unreleased bug fixes, it may save you some time. Currently we are not really using this unreleased section of the changelog https://github.com/Project-MONAI/MONAI/blob/dev/CHANGELOG.md#unreleased cc@Nic-Ma

@xxsxxsxxs666 really helped a lot by creating a small script for reproducing the issue #5935.