Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4462 dataset summary for metatensor #4728

Merged
merged 3 commits into from
Jul 20, 2022
Merged

4462 dataset summary for metatensor #4728

merged 3 commits into from
Jul 20, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 20, 2022

Signed-off-by: Wenqi Li [email protected]

part of #4462

Description

revise DatasetSummary to support MetaTensor

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, rijobro, yiheng-wang-nv and ericspod and removed request for Nic-Ma and rijobro July 20, 2022 07:53
@wyli wyli mentioned this pull request Jul 20, 2022
Closed
12 tasks
Nic-Ma
Nic-Ma approved these changes Jul 20, 2022
View reviewed changes
monai/data/dataset_summary.py Outdated Show resolved Hide resolved
@wyli
fixes tests
1c6a30e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor Author

wyli commented Jul 20, 2022

/build

@wyli wyli enabled auto-merge (squash) July 20, 2022 10:17
@wyli wyli merged commit 73cd27e into Project-MONAI:dev Jul 20, 2022
@wyli wyli deleted the reenable-tests branch July 20, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyli @Nic-Ma @yiheng-wang-nv