Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4258 Add TCIA dataset #4610

Merged
merged 36 commits into from
Jul 19, 2022
Merged

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jun 29, 2022

Signed-off-by: Yiheng Wang [email protected]

Fixes #4258 .

Description

This PR is used to:

  1. add TciaDataset, which is able to download and data from TCIA.
  2. enhance PydicomReader to support load dicom data with modality "SEG"

Dataset download and load images

I've tested with the following collections with seg_type = "SEG":

  • LIDC-IDRI
  • C4KC-KiTS
  • NSCLC Radiogenomics
  • NSCLC-Radiomics
  • NSCLC-Radiomics-Interobserver1
  • PROSTATEx
  • QIN LUNG CT
  • QIN-PROSTATE-Repeatability
  • RIDER Lung CT

Also tested with the following collections with seg_type = "RTSTRUCT":

  • Pancreatic-CT-CBCT-SEG
  • Pediatric-CT-SEG
  • LCTSC
  • 4D-Lung

load "SEG" data

For collections that contain modality "SEG", if tag "PerFrameFunctionalGroupsSequence" exists for each frame of the dicom file, the reader is able to load the data (this method refers to: Highdicom ). Therefore, for the collections with seg_type = "SEG" mentioned above, some of them cannot be recognized:

  • LIDC-IDRI
  • NSCLC Radiogenomics
  • QIN LUNG CT
  • RIDER Lung CT

Status

Ready

progresses:

  • Implement TciaDataset

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv requested a review from wyli July 8, 2022 08:20
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review July 13, 2022 08:39
@yiheng-wang-nv
Copy link
Contributor Author

Hi @kirbyju and @AHarouni , could you please help to review this PR? Thanks!

monai/apps/datasets.py Outdated Show resolved Hide resolved
Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
monai/apps/datasets.py Outdated Show resolved Hide resolved
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Contributor Author

/black

Signed-off-by: monai-bot <[email protected]>
@yiheng-wang-nv yiheng-wang-nv requested a review from wyli July 18, 2022 13:02
@wyli
Copy link
Contributor

wyli commented Jul 19, 2022

/black

@wyli
Copy link
Contributor

wyli commented Jul 19, 2022

/build

@wyli wyli enabled auto-merge (squash) July 19, 2022 07:32
@wyli wyli disabled auto-merge July 19, 2022 07:36
@wyli
Copy link
Contributor

wyli commented Jul 19, 2022

/black

@wyli wyli enabled auto-merge (squash) July 19, 2022 09:05
@wyli
Copy link
Contributor

wyli commented Jul 19, 2022

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor

wyli commented Jul 19, 2022

/build

@wyli wyli merged commit 422cc6d into Project-MONAI:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monai Dataset subclass for TCIA Rest API
4 participants