Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add box convert to world coordinate transform #4476

Merged
merged 2 commits into from
Jun 10, 2022
Merged

add box convert to world coordinate transform #4476

merged 2 commits into from
Jun 10, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Jun 10, 2022 •
edited
Loading

Signed-off-by: Can Zhao [email protected]

Fixes # .

Description

add box convert to world coordinate transform

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao marked this pull request as ready for review June 10, 2022 05:15
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli June 10, 2022 05:15
@wyli
Copy link
Contributor

wyli commented Jun 10, 2022

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Jun 10, 2022

/build

wyli
wyli approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change to include a wrapper for converter_to_world_coordinate

@wyli wyli merged commit 1daf220 into Project-MONAI:dev Jun 10, 2022
@wyli wyli deleted the physical_transform branch June 10, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Can-Zhao @wyli