Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Efficient GridPatch and RandGridPatch V2 #4473

Merged
merged 9 commits into from
Jun 13, 2022

Conversation

bhashemian
Copy link
Member

@bhashemian bhashemian commented Jun 8, 2022

Fixes #4472

Description

This PR fixes the performance issue of GridPatch with the minimal changes and no API change.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

@bhashemian
Copy link
Member Author

/black

Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests worked fine as @myron suggested.

@wyli
Copy link
Contributor

wyli commented Jun 13, 2022

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Jun 13, 2022

/build

@wyli wyli enabled auto-merge (squash) June 13, 2022 04:24
@wyli wyli merged commit 0b97bb6 into Project-MONAI:dev Jun 13, 2022
@bhashemian bhashemian deleted the improved-grid-patch branch February 22, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridPatch Performance Issue
4 participants