Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coco detection metrics #4447

Merged
merged 23 commits into from
Jun 7, 2022
Merged

Add coco detection metrics #4447

merged 23 commits into from
Jun 7, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Jun 3, 2022 •
edited
Loading

Signed-off-by: Can Zhao [email protected]

Fixes #3748 .

Description

Add coco detection metrics

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao
docstring
9ce4575 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone Jun 3, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review June 3, 2022 04:31
@Can-Zhao
Copy link
Collaborator Author

Can-Zhao commented Jun 3, 2022

/black

@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli June 3, 2022 04:42
@Can-Zhao Can-Zhao requested a review from mibaumgartner June 4, 2022 03:50
@wyli
Copy link
Contributor

wyli commented Jun 6, 2022

minor issues here https://deepsource.io/gh/Project-MONAI/MONAI/run/7b7fec11-60f6-4519-8701-423a508b9239/python/

Can-Zhao and others added 7 commits June 6, 2022 21:39
@Can-Zhao
fix assert
e260f7c 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
fix bug
8d6ef37 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
Merge branch 'dev' into coco
d286298
@Can-Zhao
reformat
2aa26d7 
Signed-off-by: Can Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
eb5cbae 
for more information, see https://pre-commit.ci
@Can-Zhao
reformat
c2fd3b2 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
reformat
593f668 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
Copy link
Collaborator Author

Can-Zhao commented Jun 7, 2022

minor issues here https://deepsource.io/gh/Project-MONAI/MONAI/run/7b7fec11-60f6-4519-8701-423a508b9239/python/

Fixed. Thanks!

@wyli
Copy link
Contributor

wyli commented Jun 7, 2022

/build

@wyli wyli enabled auto-merge (squash) June 7, 2022 15:26
@wyli wyli merged commit 7d77322 into Project-MONAI:dev Jun 7, 2022
@Can-Zhao Can-Zhao deleted the coco branch June 8, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@mibaumgartner mibaumgartner Awaiting requested review from mibaumgartner

Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
Detection module [P0]
Development

Successfully merging this pull request may close these issues.

Box evaluation metrics
2 participants
@Can-Zhao @wyli