Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add box selector #4437

Merged
merged 10 commits into from
Jun 2, 2022
Merged

add box selector #4437

merged 10 commits into from
Jun 2, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Jun 1, 2022

Signed-off-by: Can Zhao [email protected]

Fixes #3576. Fix #4416.

Description

split box selection in detection inference out into BoxSelector
make box coder more general (not used in retinanet, but might be used in faster rcnn)
add batch nms

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone Jun 1, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review June 1, 2022 21:38
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao requested review from wyli, Nic-Ma and mibaumgartner June 1, 2022 21:44
Can-Zhao added 3 commits June 1, 2022 17:47
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilities for selecting candidate boxes

@wyli
Copy link
Contributor

wyli commented Jun 1, 2022

/build

@wyli wyli enabled auto-merge (squash) June 1, 2022 22:01
@wyli
Copy link
Contributor

wyli commented Jun 1, 2022

/build

Signed-off-by: Can Zhao <[email protected]>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jun 2, 2022

/build

@wyli wyli merged commit bbc628d into Project-MONAI:dev Jun 2, 2022
@Can-Zhao Can-Zhao deleted the box_selector branch June 2, 2022 02:50
@Can-Zhao Can-Zhao mentioned this pull request Jun 2, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add batch_nms to box util Box selector
3 participants