Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add random foreground crop for boxes #4388

Merged
merged 13 commits into from
Jun 2, 2022
Merged

add random foreground crop for boxes #4388

merged 13 commits into from
Jun 2, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented May 30, 2022 •
edited
Loading

Signed-off-by: Can Zhao [email protected]

Fixes #3572 .

Description

add random foreground crop for boxes

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 30, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review May 30, 2022 09:55
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 30, 2022 09:55
@Can-Zhao Can-Zhao marked this pull request as draft May 30, 2022 09:57
@Can-Zhao Can-Zhao marked this pull request as ready for review May 30, 2022 16:42
Nic-Ma
Nic-Ma reviewed May 31, 2022
View reviewed changes
monai/apps/detection/transforms/array.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/box_ops.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/dictionary.py Show resolved Hide resolved
Nic-Ma
Nic-Ma approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
It overall looks good to me now.
Put some minor comments inline.

Thanks.

monai/apps/detection/transforms/box_ops.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/box_ops.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/dictionary.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/dictionary.py Outdated Show resolved Hide resolved
@Can-Zhao
Copy link
Collaborator Author

Can-Zhao commented Jun 2, 2022

/black

monai-bot and others added 2 commits June 2, 2022 04:54
@wyli
Copy link
Contributor

wyli commented Jun 2, 2022

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Jun 2, 2022

/build

@wyli wyli enabled auto-merge (squash) June 2, 2022 10:25
@wyli
fixes typing
98c364d 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor

wyli commented Jun 2, 2022

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Jun 2, 2022

/build

@wyli wyli merged commit bbb35e2 into Project-MONAI:dev Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli Awaiting requested review from wyli

Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
Detection module [P0]
Development

Successfully merging this pull request may close these issues.

Box transforms
4 participants
@Can-Zhao @wyli @Nic-Ma @monai-bot