4323 deprecate SegmentationSaver, TorchVisionFullyConvModel

[wyli]

Signed-off-by: Wenqi Li [email protected]

part of #4323 for 0.9 release

Description

remove the promised deprecation

• SegmentationSaver (use SaveImage instead)
  

  MONAI/monai/handlers/segmentation_saver.py

  Line 29 in eb60b9c

  @deprecated(since="0.6.0", removed="0.9.0", msg_suffix="Please consider using `SaveImage[d]` transform instead.")

• TorchVisionFullyConvModel (use TorchVisionFCModel instead)
  

  MONAI/monai/networks/nets/torchvision_fc.py

  Line 77 in eb60b9c

  @deprecated(since="0.6.0", removed="0.9.0", msg_suffix="Please consider using `TorchVisionFCModel` instead.")

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

Hi @wyli ,

Should we also remove other deprecated APIs? May I know why only remove SegmentationSaver and TorchVisionFullyConvModel?

Thanks.

[wyli]

Hi @wyli ,

Should we also remove other deprecated APIs? May I know why only remove SegmentationSaver and TorchVisionFullyConvModel?

Thanks.

We put v0.9 in the 'removed' field of the warning msg

[wyli]

/build