Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add box non_max_suppression #4337

Merged
merged 7 commits into from
May 25, 2022
Merged

add box non_max_suppression #4337

merged 7 commits into from
May 25, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented May 24, 2022

Signed-off-by: Can Zhao [email protected]

Fixes #4244 .

Description

add box non_max_suppression. This is python version.
In the future, we may add cuda version.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao and others added 3 commits May 24, 2022 18:35
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 24, 2022
@Can-Zhao Can-Zhao linked an issue May 24, 2022 that may be closed by this pull request
@Can-Zhao
Copy link
Collaborator Author

/black

Signed-off-by: monai-bot <[email protected]>
@Can-Zhao Can-Zhao marked this pull request as ready for review May 24, 2022 23:16
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 24, 2022 23:17
Signed-off-by: Can Zhao <[email protected]>
monai/data/box_utils.py Show resolved Hide resolved
@wyli
Copy link
Contributor

wyli commented May 25, 2022

/build

@wyli wyli enabled auto-merge (squash) May 25, 2022 12:09
@wyli wyli merged commit eb60b9c into Project-MONAI:dev May 25, 2022
@Can-Zhao Can-Zhao deleted the nms branch May 25, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box utils components
3 participants