Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta tensor spatial resample #4332

Merged

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented May 24, 2022

Description

SpatialResample for MetaTensor. Array transform includes inverse.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.

@rijobro rijobro requested review from wyli, ericspod and Nic-Ma May 24, 2022 13:00
@rijobro rijobro changed the base branch from dev to feature/MetaTensor May 24, 2022 13:00
@rijobro rijobro force-pushed the MetaTensor_SpatialResample branch from 3b3d310 to a37d416 Compare May 24, 2022 13:01
@wyli
Copy link
Contributor

wyli commented May 24, 2022

this is needed 224ef3b because of the branch conflicts...

@rijobro
Copy link
Contributor Author

rijobro commented May 24, 2022

@wyli thanks, merged.

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro force-pushed the MetaTensor_SpatialResample branch from 08702d9 to 2c00f4d Compare May 26, 2022 13:17
rijobro and others added 3 commits May 26, 2022 17:30
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the MetaTensor_SpatialResample branch from 5bed75a to b33918b Compare May 27, 2022 01:20
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I went through the implementation and the unit tests work fine.

@wyli wyli merged commit 86863ac into Project-MONAI:feature/MetaTensor May 27, 2022
@rijobro rijobro deleted the MetaTensor_SpatialResample branch May 27, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants