Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add box mode convert transform #4302

Merged
merged 7 commits into from
May 20, 2022
Merged

add box mode convert transform #4302

merged 7 commits into from
May 20, 2022

Conversation

Can-Zhao
Copy link
Collaborator

Signed-off-by: Can Zhao [email protected]

Fixes #3572 .

Description

add box mode convert transform

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 2 commits May 20, 2022 03:05
@Can-Zhao
add box transform
9a30540 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
update docstring
fe3598d 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 20, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review May 20, 2022 07:09
@Can-Zhao
Copy link
Collaborator Author

/black

@monai-bot
[MONAI] code formatting
f12c0c9 
Signed-off-by: monai-bot <[email protected]>
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 20, 2022 07:15
Nic-Ma
Nic-Ma reviewed May 20, 2022
View reviewed changes
monai/apps/detection/transforms/array.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/array.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/array.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/dictionary.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/dictionary.py Outdated Show resolved Hide resolved
tests/test_box_transform.py Outdated Show resolved Hide resolved
wyli
wyli approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, there's one missing __init__.py, I'll add and merge this PR.

@wyli
add __init__
bb0b191 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor

wyli commented May 20, 2022 •
edited
Loading

/black
/build

@wyli wyli enabled auto-merge (squash) May 20, 2022 16:31
@wyli wyli merged commit e58086d into Project-MONAI:dev May 20, 2022
@Can-Zhao Can-Zhao deleted the box_transform branch May 20, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma left review comments

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
Detection module [P0]
Development

Successfully merging this pull request may close these issues.

Box transforms
4 participants
@Can-Zhao @wyli @Nic-Ma @monai-bot