Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hard_negative_sampler.py for detection #4301

Merged
merged 33 commits into from
May 31, 2022
Merged

add hard_negative_sampler.py for detection #4301

merged 33 commits into from
May 31, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented May 20, 2022 •
edited by wyli
Loading

Signed-off-by: Can Zhao [email protected]

Fixes #4300.

Fixes #4405

Description

add hard_negative_sampler.py
make it a general sampler for classification tasks.
add unit test

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 3 commits May 19, 2022 22:40
@Can-Zhao
add sampler, fpn
fafdef5 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
add sampler
a9240c8 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
add sampler
bfa21e3 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 20, 2022
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 20, 2022 02:45
@Can-Zhao Can-Zhao marked this pull request as ready for review May 20, 2022 02:46
@Can-Zhao
Copy link
Collaborator Author

/black

@wyli
Copy link
Contributor

wyli commented May 20, 2022

Cc @mibaumgartner @dongyang0122 could you please have a look if you have time? this is part of the detection pipeline.

@Can-Zhao Can-Zhao marked this pull request as draft May 21, 2022 00:13
@Can-Zhao Can-Zhao marked this pull request as ready for review May 27, 2022 18:30
@Can-Zhao
Copy link
Collaborator Author

/black

mibaumgartner
mibaumgartner reviewed May 30, 2022
View reviewed changes
Copy link
Collaborator

@mibaumgartner mibaumgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

monai/apps/detection/utils/hard_negative_sampler.py Show resolved Hide resolved
wyli
wyli approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds indices samplers based on the predictive scores.

@wyli
Copy link
Contributor

wyli commented May 31, 2022

/build

@wyli wyli enabled auto-merge (squash) May 31, 2022 07:51
@wyli wyli merged commit a75dd05 into Project-MONAI:dev May 31, 2022
@Can-Zhao Can-Zhao deleted the detection_net branch June 1, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongyang0122 dongyang0122 dongyang0122 left review comments

@mibaumgartner mibaumgartner mibaumgartner left review comments

@Nic-Ma Nic-Ma Nic-Ma left review comments

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
Detection module [P0]
5 participants
@Can-Zhao @wyli @dongyang0122 @mibaumgartner @Nic-Ma