Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the order of slices row-major #4297

Merged
merged 3 commits into from
May 19, 2022
Merged

Make the order of slices row-major #4297

merged 3 commits into from
May 19, 2022

Conversation

bhashemian
Copy link
Member

Fixes #4287

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli
wyli reviewed May 19, 2022
View reviewed changes
monai/data/utils.py Outdated Show resolved Hide resolved
@bhashemian
Remove a comment
38f905d 
Signed-off-by: Behrooz <[email protected]>
wyli
wyli approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I'll merge this one if all tests work fine.

@wyli
Copy link
Contributor

wyli commented May 19, 2022

/build

@wyli wyli enabled auto-merge (squash) May 19, 2022 18:01
@wyli wyli merged commit 1ff12b9 into Project-MONAI:dev May 19, 2022
@bhashemian bhashemian deleted the update-slice-order branch February 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iter_patch_slices Patch Order
2 participants
@bhashemian @wyli