Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_extra_metadata etc transforms/utils.py -> data/utils.py #4296

Merged
merged 9 commits into from
May 19, 2022
Merged

remove_extra_metadata etc transforms/utils.py -> data/utils.py #4296

merged 9 commits into from
May 19, 2022

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented May 19, 2022

Fixes circular import cf #4294 (comment).

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@rijobro rijobro requested a review from wyli May 19, 2022 13:27
@wyli
Copy link
Contributor

wyli commented May 19, 2022

/black

@monai-bot
[MONAI] code formatting
151c6dc 
Signed-off-by: monai-bot <[email protected]>
wyli
wyli approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, there are a few issues because of the merging conflicts according to the tests, could you help fix @rijobro?

rijobro added 7 commits May 19, 2022 16:48
@rijobro
fix
52f9d0a 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
fixes
338dffb 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
bug fixes
eb111ed 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
fixes
b39ef42 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
fixes to test_inverse
67352e3 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
fixes
19a5912 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
fixxx
7813b52 
Signed-off-by: Richard Brown <[email protected]>
@wyli wyli merged commit 1bd2c8c into Project-MONAI:feature/MetaTensor May 19, 2022
@rijobro rijobro deleted the remove_extra_metadata_to_data_submodule branch May 19, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rijobro @wyli @monai-bot