Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4269 - fixes resample mode typos #4272

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented May 13, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #4269

Description

prefer self.mode when mode is not provided by the user.

I searched through transforms/**/array.py, cannot find additional bugs

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from rijobro, Nic-Ma and ericspod May 13, 2022 18:00
@wyli wyli enabled auto-merge (squash) May 13, 2022 22:18
@wyli
Copy link
Contributor Author

wyli commented May 13, 2022

/build

@wyli wyli merged commit db34747 into Project-MONAI:dev May 13, 2022
@wyli wyli deleted the 4269-spatial-resample branch June 11, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor mode argument ignored in SpatialResample
2 participants