Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update integration tests metatensor #4262

Merged
merged 6 commits into from
May 12, 2022
Merged

update integration tests metatensor #4262

merged 6 commits into from
May 12, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented May 12, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

fixes integration tests for the updated metatensor transforms

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 6 commits May 12, 2022 08:47
@wyli
temp tests
4865672 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp test
f939c53 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes rotated test
791df7a 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
mednist dataset fix
a541c9f 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes
90c4bd0 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
remove temp tests
c805baf 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review May 12, 2022 14:50
@wyli wyli requested review from Nic-Ma and rijobro May 12, 2022 14:50
@wyli
Copy link
Contributor Author

wyli commented May 12, 2022

the integration looks good now https://github.com/Project-MONAI/MONAI/actions/runs/2312830476

@wyli wyli merged commit e6d1645 into Project-MONAI:feature/MetaTensor May 12, 2022
@wyli wyli deleted the feature-tests-metatensor branch May 12, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @Nic-Ma