Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding discussion on format to bundle specification #4047

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Apr 1, 2022

Signed-off-by: Eric Kerfoot [email protected]

Addresses #4049.

Description

Relating to our discussion about the correctness of defining the output's value range, I've added a fuller description of what an input/output tensor's format it, how this relates to its type, and added a field for modality. This should be discussed further to ensure it covers the relevant information for users and can cover future cases of non-image data which is the direction we are headed with MONAI.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor

wyli commented Apr 4, 2022

/build

@wyli wyli merged commit dc7a5b2 into Project-MONAI:dev Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants