Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting arbitrary num_fold in AutoRunner is permitted regardless the Auto3DSeg datalist doesn't support #7628

Closed
mingxin-zheng opened this issue Apr 11, 2024 · 0 comments · Fixed by #7634
Closed

Setting arbitrary num_fold in AutoRunner is permitted regardless the Auto3DSeg datalist doesn't support #7628

mingxin-zheng opened this issue Apr 11, 2024 · 0 comments · Fixed by #7634
Assignees
@mingxin-zheng

Comments

@mingxin-zheng
Copy link
Contributor

mingxin-zheng commented Apr 11, 2024 •
edited
Loading

Describe the bug

The num_fold in AutoRunner is not checked in the Auto3DSeg pipeline. As a result, the BundleGen would create templated algorithms (dints_0, dints_1, dints_<num_fold>) even if there aren't num folds in the datalist.

To Reproduce

work_dir = "./work_dir"
input = "path/to/input_yaml"
runner = AutoRunner(work_dir=work_dir, input=input)
runner.set_num_fold(n_fold=10000)

Expected behavior
Should raise an error if the num fold exceeds the max
@mingxin-zheng mingxin-zheng self-assigned this Apr 11, 2024
@mingxin-zheng mingxin-zheng mentioned this issue Apr 12, 2024
Merged
6 tasks
KumoLiu added a commit that referenced this issue Apr 12, 2024
@mingxin-zheng @KumoLiu
Add checks for num_fold and fail early if wrong (#7634)
9e2904a 
Fixes #7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <[email protected]>
Co-authored-by: YunLiu <[email protected]>
freddiewanah pushed a commit to freddiewanah/MONAI that referenced this issue Apr 17, 2024
@mingxin-zheng @KumoLiu @freddiewanah
Add checks for num_fold and fail early if wrong (Project-MONAI#7634)
30d9af4 
Fixes Project-MONAI#7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <[email protected]>
Co-authored-by: YunLiu <[email protected]>
freddiewanah pushed a commit to freddiewanah/MONAI that referenced this issue Apr 17, 2024
@mingxin-zheng @KumoLiu @freddiewanah
Add checks for num_fold and fail early if wrong (Project-MONAI#7634)
adc6f1e 
Fixes Project-MONAI#7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <[email protected]>
Co-authored-by: YunLiu <[email protected]>
freddiewanah pushed a commit to freddiewanah/MONAI that referenced this issue Apr 17, 2024
@mingxin-zheng @KumoLiu @freddiewanah
Add checks for num_fold and fail early if wrong (Project-MONAI#7634)
9166cf5 
Fixes Project-MONAI#7628 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin <[email protected]>
Co-authored-by: YunLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mingxin-zheng mingxin-zheng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checks for num_fold and fail early if wrong
1 participant
@mingxin-zheng